X-Git-Url: http://git.pjr.cc/?p=CBFWR.git;a=blobdiff_plain;f=libcbfwr%2Ffwui.php;h=bb2fc8e7b935e4d32d69d888f66744bf7b22ae5e;hp=e827c2ca879676fd4af03b2940af6e27a0aa8e16;hb=482faf0546015989a57b68640fd9a1ff5e8666f2;hpb=86842492eae6203c9df0df46363b4e809d577c70
diff --git a/libcbfwr/fwui.php b/libcbfwr/fwui.php
index e827c2c..bb2fc8e 100644
--- a/libcbfwr/fwui.php
+++ b/libcbfwr/fwui.php
@@ -58,15 +58,8 @@ function CBFWZonesPage($urls)
case "delete":
$zonetodelete = $urls[2];
-
- $conf = $comms->getConfig(3);
- $changes = $conf["status"];
- if($changes == "nochange") $conf["status"] = 1;
- else $conf["status"] = $changes + 1;
- $cnum = $conf["status"];
-
- $conf[$cnum]["delete"] = "zone $zonetodelete";
- $comms->putConfig($conf, 3);
+
+ addWebUserChange("delete zone name $zonetodelete");
header("Location: $BASE_URL/zones");
break;
@@ -74,21 +67,16 @@ function CBFWZonesPage($urls)
case "add":
// UGLY
- $cnum = 0;
$nametoadd = $_REQUEST["toadd"];
$desc = $_REQUEST["desc"];
+
$descbit = "";
if($desc != "") $descbit = " # $desc";
if($nametoadd == "" || $nametoadd == null) {
return;
}
- $conf = $comms->getConfig(3);
- $changes = $conf["status"];
- if($changes == "nochange") $conf["status"] = 1;
- else $conf["status"] = $changes + 1;
- $cnum = $conf["status"];
- $conf[$cnum]["add"] = "zone $nametoadd$descbit";
- $comms->putConfig($conf, 3);
+
+ addWebUserChange("zone name $nametoadd $descbit");
header("Location: $BASE_URL/zones");
break;
@@ -122,6 +110,28 @@ function CBFWZonesEditPage($urls)
echo "";
}
+function addWebUserChange($change)
+{
+ $comms = new Comms();
+ $myconf = new Config();
+
+ $conf = $comms->getConfig(3);
+
+ if(!isset($conf["status"])) {
+ $conf["status"] = "nochange";
+ }
+
+ $changes = $conf["status"];
+ if($changes == "nochange") $conf["status"] = 1;
+ else $conf["status"] = $changes + 1;
+ $cnum = $conf["status"];
+
+ $conf["changes"][$cnum] = "$change";
+ $comms->putConfig($conf, 3);
+
+}
+
+// TODO: we need to really sit and think about this one
function getWebUserConfig()
{
$comms = new Comms();
@@ -140,13 +150,20 @@ function getWebUserConfig()
}
// it did not, do a new merge and cache
- $config = $myconf->mergeConfig($comms->getConfig(), $conf2);
+ // TODO: need to do this part
+ $config = $comms->getConfig();
$reconfig = $config;
+ $myconf->setConfig($config);
+ if(isset($conf2["changes"])) foreach($conf2["changes"] as $key => $var) {
+ error_log("Adding config line $key, $var");
+ $myconf->addConfigLine($var);
+ }
+ $reconfig = $myconf->getConfig();
$reconfig["status"] = $conf2["status"];
error_log("put pre-cache config");
$comms->putConfig($reconfig, 5);
- return $config;
+ return $reconfig;
}
function CBFWZonesPageDisplay()
@@ -229,9 +246,16 @@ function CBFWInterfacesPageDisplay()
global $BASE_URL, $MENU_ITEMS;
$comms = new Comms();
- $config = $comms->getConfig(0);
+ $config = getWebUserConfig();
$boot_config = $comms->getConfig(1);
+ // at the top, we put in the creation bits
+ echo "
Create Interface
";
+ echo "Link Aggregation Group (bonded/teamed interfaces)
";
+ echo "VLAN Tagged Sub Interfaces
";
+ echo "Bridged Interfaces
";
+ echo "
";
+
// now build an interface table
$table = array();
foreach($boot_config["hardware"]["netdev"] as $key=>$val) {
@@ -249,89 +273,88 @@ function CBFWInterfacesPageDisplay()
// current mtu
if(isset($val["mtu"])) $table[$key]["mtu"] = $val["mtu"];
- }
-
- foreach($config["hardware"]["netdev"] as $key=>$val) {
- $ename = $key;
- if(isset($config["interface"]["$key"]["name"])) $table[$key]["name"] = $config["interface"]["$key"]["name"];
- $table[$key]["address4"] = null;
- $table[$key]["address6"] = null;
-
- if(isset($config["interface"][$table[$key]["name"]]["address4"])) {
- $table[$key]["address4"] = $config["interface"][$table[$key]["name"]]["address4"];
- }
- if(isset($config["interface"][$table[$key]["name"]]["address6"])) {
- $table[$key]["address6"] = $config["interface"][$table[$key]["name"]]["address6"];
- }
+ // speed
+ if(isset($val["speed"])) $table[$key]["speed"] = $val["speed"];
+ else $table[$key]["speed"] = "default";
- if(isset($config["interface"][$table[$key]["name"]]["mtu"])) {
- $table[$key]["mtu"] = $config["interface"][$table[$key]["name"]]["mtu"];
- } else {
- $table[$key]["mtu"] = "1500"; // TODO: this needs to actually come from somewhere
- }
-
- if(isset($config["interface"][$table[$key]["name"]]["speed"])) {
- $table[$key]["speed"] = $config["interface"][$table[$key]["name"]]["speed"];
- } else {
- $table[$key]["speed"] = null;
- }
-
- if(isset($config["interface"][$table[$key]["name"]]["duplex"])) {
- $table[$key]["duplex"] = $config["interface"][$table[$key]["name"]]["duplex"];
- } else {
- $table[$key]["duplex"] = null;
- }
-
- if(isset($config["interface"][$table[$key]["name"]]["zone"])) {
- $table[$key]["zone"] = $config["interface"][$table[$key]["name"]]["zone"];
- } else {
- $table[$key]["zone"] = null;
- }
+ // duplex
+ if(isset($val["duplex"])) $table[$key]["duplex"] = $val["duplex"];
+ else $table[$key]["duplex"] = "default";
}
+ foreach($config["interface"]["dev"] as $key => $val) {
+ // TODO construction zone
+ error_log("doing $key");
+ if(isset($val["name"])) $table[$key]["name"] = $val["name"];
+ if(isset($val["address4"])) $table[$key]["address4"] = $val["address4"];
+ if(isset($val["address6"])) $table[$key]["address6"] = $val["address6"];
+ if(isset($val["description"])) $table[$key]["description"] = $val["description"];
+ if(isset($val["zone"])) $table[$key]["zone"] = $val["zone"];
+ }
+
- echo "